Change Go to use net.FD for peer and host #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
approved these changes
Apr 11, 2024
Comment on lines
+6
to
+7
| #define MAX_CONCURRENT_REQUESTS 10000 // 10000 requests per second max for a single traced process | ||
| #define MAX_CONCURRENT_SHARED_REQUESTS 30000 // 10 * MAX_CONCURRENT_REQUESTS total ongoing requests, for maps shared among multiple tracers, e.g. pinned maps |
There was a problem hiding this comment.
We could address this as another task, for other maps too: you can move the map sizing from compile-time to runtime and let the user decide the size (this way we could troubleshoot better).
This is how the Network Metrics side does it at the user side, from the user configuration:
https://github.com/grafana/beyla/blob/main/pkg/internal/netolly/ebpf/tracer.go#L85-L86
The aggregated_flows map does not define any size when it is compiled:
https://github.com/grafana/beyla/blob/main/bpf/flows.c#L56-L60
There was a problem hiding this comment.
Ah great point, I'll follow-up with a configuration option. 1000 was way too small, too many collisions on my 20 core machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all host, peer parsing for Go in eBPF, rely on getting the information consistently from the connection information.